how do i change my credit card for i cloud storage

There are several ways to change you payment method, including on your computer, or iOS device, or also through the web browser. Attached here is a linked support article: https://support.apple.com/en-us/HT201266

If you want to change your payment type on iMac, you still need to go in through the App Store app, as outlined in the support article instructions.